feat: comments frontend #19303

daibhin · 2023-12-13T09:34:15Z

Problem

Frontend follow-on from #19272

Changes

Add types and api methods
Use marks for inline text comments
Use right hand sidebar for composition
Add option to create comment from the inline menu

TODO

Maybe pull out comments into a "Discussion" panel
Correctly load comments for the page you are looking at
Fix Comments -> activity log (doesn't seem to create a log entry
Markdown support (or mini tiptap editor)
Reverse chronological pagination of comments
Threading / replies
Correct generic discussion - currently its only URL based
Load just the comment count when viewing a page for speedy checking
Add feature flag

How did you test this code?

WIP

* Don't show keyboard shortcuts on mobile * Fix overflow handling in some places for mobile * Reduce scope of keyboard shortcut mobile check

* Add tests to diagnose the issue * Add THE test * Implement the fix * Update query snapshots * Update query snapshots * Ignore mypy's ignorance --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* feat: allow local file playback of mobile recordings * fix up progress spinner styles * Update UI snapshots for `chromium` (1) * normalise export window id * Revert "normalise export window id" This reverts commit c86d7e4c64e7f9a04a41bb8b88c7c2323957d9e1. * add a comment * fix * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update query snapshots * snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

…ults, for graph of all time (#19282)

…default q… (#19283) Quick fix for ensuring future events dont show in team apps default query

* temp * add format * remove unnecessary * remove unused ignore * temp test

* add feature flag for inviting team member step, implement step * undo launch json changes * fix feature flag check * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * spice up the onboarding copy * extract invite modal logic into common component * move hogs / update language --------- Co-authored-by: Bianca Yang <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Raquel Smith <[email protected]>

…19292)

…19298) fix the invite team member step in onboarding Co-authored-by: Bianca Yang <[email protected]>

* swaped down carets for chevrons * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * Update query snapshots * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update query snapshots * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (1) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben White <[email protected]> Co-authored-by: Michael Matloka <[email protected]>

* add widget to surveys UI * add widget to survey appearance * add beta tag and flag * fix template titles * Update UI snapshots for `chromium` (2) * migration for type * migration file * move widget customization into customization panel * fix migration conflict --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

…19293) * remove haerbeating and resume logic for now * dont flatten metadata * reduce number of retries * Update query snapshots * Update query snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

posthog-bot · 2023-12-15T09:38:35Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-12-15T09:46:25Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-12-15T10:03:11Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-12-15T10:10:58Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

* fix: no console logging of schema validation * move validation behind a (n unused) boolean check * Fix

…twork events (#19353) Found some major perf improvements when parsing large numbers of network events

* feat: ingest with snapshot source * add replay events ingester tests * fix test data insertion * add test * Update query snapshots * fix test * fix test * fix test --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

# Conflicts: # frontend/__snapshots__/scenes-app-experiments--running-trend-experiment.png # frontend/__snapshots__/scenes-app-insights--trends-area-breakdown--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-area-edit--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line-multi-edit--webkit.png # latest_migrations.manifest

posthog-bot · 2023-12-15T14:23:42Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 0 modified, 0 deleted
webkit: 0 added, 3 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…nto feat/comments-frontend

posthog-bot and others added 20 commits December 12, 2023 06:22

chore(deps): Update posthog-js to 1.94.3 (#19269)

ca32acf

fix(3000): Look reasonable on mobile (#19262)

28a3663

* Don't show keyboard shortcuts on mobile * Fix overflow handling in some places for mobile * Reduce scope of keyboard shortcut mobile check

chore(deps): Update posthog-js to 1.94.4 (#19276)

5c6fc5e

fix(web-analytics): Fix bug where we tried to compare to previous res…

3c3eaa9

…ults, for graph of all time (#19282)

fix(bi): quick fix for ensuring future events dont show in team apps …

bf1d3d2

…default q… (#19283) Quick fix for ensuring future events dont show in team apps default query

chore(data-warehouse): use sync imports (#19261)

fcf9e57

* temp * add format * remove unnecessary * remove unused ignore * temp test

chore(plugin-server): remove pg from possible plugin imports (#19284)

150e62b

fix(plugin-server): add more fields to rusty-hook payload (#19288)

e3b2c9f

fix(experiments): Improve legibility of secondary metrics variants (#…

5163925

…19292)

feat(schedule flags): add scheduled changes API (#19201)

5d1ed0b

fix: Actually send emails to team members when invited in onboarding (#…

2a4be26

…19298) fix the invite team member step in onboarding Co-authored-by: Bianca Yang <[email protected]>

chore(deps): Update posthog-js to 1.95.0 (#19299)

74a06f1

chore(deps): Update posthog-js to 1.95.1 (#19302)

6b5b801

feat: comments frontend in notebooks

6680dea

daibhin assigned daibhin and benjackwhite Dec 13, 2023

benjackwhite changed the base branch from master to feat/comments-2 December 13, 2023 09:39

pauldambra and others added 7 commits December 13, 2023 09:51

feat: first pass ratings bar for mobile wireframes (#19287)

e163bac

fix(unwrapped): Fix capitalization (#19290)

d195b3d

fix(insights): adapt aggregation table title for 3000 (#19278)

b2dfd00

fix(3000): fix various layout issues (#19297)

236ac85

fix: selected row sticky cell background color in dark mode (#19280)

dfd65ae

fix: notebook node buttons hover (#19186)

5583607

fix: Fix geoip not containing postal_code for UK (#19307)

cab8aea

Update UI snapshots for chromium (2)

d68793a

benjackwhite and others added 2 commits December 15, 2023 10:55

Added comment replies

d0fff82

Update UI snapshots for chromium (2)

707a2ff

Update UI snapshots for chromium (2)

7741894

pauldambra and others added 14 commits December 15, 2023 11:47

fix: no console logging on schema (#19349)

7cd9e14

* fix: no console logging of schema validation * move validation behind a (n unused) boolean check * Fix

fix(performance): Fix performance issue when parsing large list of ne…

9a3b48b

…twork events (#19353) Found some major perf improvements when parsing large numbers of network events

Fixes

2757189

Fix styles

90071c6

Fixed deletion

711dc3a

Style tweaks

28ebad0

Fixes

a2c391d

Added stories

148b941

Update UI snapshots for chromium (1)

85ad7e4

Update UI snapshots for chromium (2)

a8a7734

Fix

1bb278a

Update UI snapshots for webkit (2)

a86a5bd

benjackwhite added 3 commits December 15, 2023 15:51

Added empty state

44c3e99

Merge branch 'feat/comments-frontend' of github.com:PostHog/posthog i…

0a90d4d

…nto feat/comments-frontend

Added feature flag

5f95f55

benjackwhite marked this pull request as ready for review December 15, 2023 15:09

benjackwhite requested a review from fuziontech as a code owner December 15, 2023 15:09

benjackwhite merged commit fd22eab into feat/comments-2 Dec 15, 2023
47 of 53 checks passed

benjackwhite deleted the feat/comments-frontend branch December 15, 2023 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: comments frontend #19303

feat: comments frontend #19303

daibhin commented Dec 13, 2023 •

edited by benjackwhite

Loading

posthog-bot commented Dec 15, 2023

posthog-bot commented Dec 15, 2023

posthog-bot commented Dec 15, 2023

posthog-bot commented Dec 15, 2023

posthog-bot commented Dec 15, 2023

feat: comments frontend #19303

feat: comments frontend #19303

Conversation

daibhin commented Dec 13, 2023 • edited by benjackwhite Loading

Problem

Changes

TODO

How did you test this code?

posthog-bot commented Dec 15, 2023

📸 UI snapshots have been updated

posthog-bot commented Dec 15, 2023

📸 UI snapshots have been updated

posthog-bot commented Dec 15, 2023

📸 UI snapshots have been updated

posthog-bot commented Dec 15, 2023

📸 UI snapshots have been updated

posthog-bot commented Dec 15, 2023

📸 UI snapshots have been updated

daibhin commented Dec 13, 2023 •

edited by benjackwhite

Loading