Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unsubscribed groups page #18849

Merged
merged 4 commits into from
Nov 23, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import { Meta, StoryFn } from '@storybook/react'
import { router } from 'kea-router'
import { useEffect } from 'react'
import { App } from 'scenes/App'
import { urls } from 'scenes/urls'

const meta: Meta = {
title: 'Scenes-App/Persons & Groups',
parameters: {
layout: 'fullscreen',
viewMode: 'story',
mockDate: '2023-07-04', // To stabilize relative dates
},
decorators: [],
}
export default meta

export const Persons: StoryFn = () => {
useEffect(() => {
router.actions.push(urls.persons())
}, [])
return <App />
}

export const Cohorts: StoryFn = () => {
useEffect(() => {
router.actions.push(urls.cohorts())
}, [])
return <App />
}

export const Groups: StoryFn = () => {
useEffect(() => {
router.actions.push(urls.groups(0))
}, [])
return <App />
}
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
...(showGroupsIntroductionPage
? [
{
key: 'groups-intro',
key: 'groups-0',
label: 'Groups',
url: urls.groups(0),
content: <Groups groupTypeIndex={0} />,
Expand Down Expand Up @@ -137,6 +137,7 @@
}),
actionToUrl(({ values }) => ({
setTabKey: ({ tabKey }) => {
console.log(values.tabs, tabKey)

Check failure on line 140 in frontend/src/scenes/persons-management/personsManagementSceneLogic.tsx

View workflow job for this annotation

GitHub Actions / Code quality checks

Unexpected console statement
benjackwhite marked this conversation as resolved.
Show resolved Hide resolved
return values.tabs.find((x) => x.key === tabKey)?.url || values.tabs[0].url
},
})),
Expand Down
Loading