Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unsubscribed groups page #18849

Merged
merged 4 commits into from
Nov 23, 2023
Merged

fix: Unsubscribed groups page #18849

merged 4 commits into from
Nov 23, 2023

Conversation

benjackwhite
Copy link
Contributor

Problem

The key for the url routing was wrong for the intro page

Changes

  • Fixes it
  • Adds a scene story to better catch it in the future

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@benjackwhite benjackwhite requested a review from a team November 23, 2023 12:34
@benjackwhite benjackwhite enabled auto-merge (squash) November 23, 2023 13:01
@benjackwhite benjackwhite enabled auto-merge (squash) November 23, 2023 13:38
@github-actions GitHub Actions
Copy link
Contributor

Size Change: 0 B

Total Size: 1.83 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.83 MB

compressed-size-action

@benjackwhite benjackwhite merged commit 4c76462 into master Nov 23, 2023
75 checks passed
@benjackwhite benjackwhite deleted the fix/groups-access branch November 23, 2023 15:55
thmsobrmlr pushed a commit that referenced this pull request Nov 23, 2023
@benjackwhite @thmsobrmlr
fix: Unsubscribed groups page (#18849)
ff8ecd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daibhin daibhin daibhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjackwhite @daibhin