fix(funnels): fix infinite scroll for wide funnels #18839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See https://posthog.slack.com/archives/C0368RPHLQH/p1700215685287799. An additional scrollbar causes the size calculation to loop.
Changes
I'm working on a proper fix, but this should fix the problem temporarily (only doesn't look good). Here we're simply subtracting the height of the scrollbar that gets added when the content gets to wide from the height of the bars. 17px is the size of scrollbars on windows apparently.
How did you test this code?
Testing with funnels in different configurations