Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(funnels): fix infinite scroll for wide funnels #18839

Merged
merged 5 commits into from
Nov 23, 2023

Conversation

thmsobrmlr
Copy link
Contributor

Problem

See https://posthog.slack.com/archives/C0368RPHLQH/p1700215685287799. An additional scrollbar causes the size calculation to loop.

Changes

I'm working on a proper fix, but this should fix the problem temporarily (only doesn't look good). Here we're simply subtracting the height of the scrollbar that gets added when the content gets to wide from the height of the bars. 17px is the size of scrollbars on windows apparently.

How did you test this code?

Testing with funnels in different configurations

Screenshot 2023-11-23 at 10 27 23 Screenshot 2023-11-23 at 10 27 32 Screenshot 2023-11-23 at 10 27 14

@thmsobrmlr thmsobrmlr requested review from a team and benjackwhite November 23, 2023 09:28
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah thats pretty nasty 😬 but makes sense to just fix this issue (just the debug log to remove)

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

15 snapshot changes in total. 0 added, 15 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr thmsobrmlr enabled auto-merge (squash) November 23, 2023 09:58
Copy link
Contributor

Size Change: +304 B (0%)

Total Size: 1.97 MB

Filename Size Change
frontend/dist/toolbar.js 1.97 MB +304 B (0%)

compressed-size-action

@thmsobrmlr thmsobrmlr merged commit dc2499d into master Nov 23, 2023
75 checks passed
@thmsobrmlr thmsobrmlr deleted the hotfix-funnel-overscroll branch November 23, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants