fix(funnels): fix infinite scroll caused by scrollbar #18848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
force-pushed
the
fix-funnnel-overscroll
branch
from
a6aa8bd to
2f7ed50
Compare
📸 UI snapshots have been updated15 snapshot changes in total. 0 added, 15 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
thmsobrmlr
commented
Nov 23, 2023
benjackwhite
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
(Hopefully) proper fix for #18839.
Changes
This PR subtracts the height of an eventual scrollbar from the available height. Have refactored existing code to hopefully leave it more understandable for the future traveller. Removed a
useMemothat I don't think is necessary.How did you test this code?
Various combinations of funnels in Chrome and Firefox while toggling the "show scrollbars" setting in Mac. Notably haven't tested on windows - would be great to verify the fix once it's in there.