chore: upgrade playwright #18793
Merged
chore: upgrade playwright #18793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
commented
Nov 21, 2023
| @@ -270,7 +270,6 @@ | |||
| "msw": "^0.49.0", | |||
| "path-browserify": "^1.0.1", | |||
| "pixelmatch": "^5.3.0", | |||
| "playwright-core": "1.29.2", | |||
There was a problem hiding this comment.
Wasn't sure if this was needed but tried removing it and nothing broke. Basing things off this release note it suggested relying on @playwright/test for types
daibhin
commented
Nov 22, 2023
| @@ -54,7 +54,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| timeout-minutes: 30 | |||
| container: | |||
| image: mcr.microsoft.com/playwright:v1.29.2 # Same as @storybook/test-runner@0.13's dependency | |||
| image: mcr.microsoft.com/playwright:v1.32.2 # Same as @storybook/test-runner@0.15.2's dependency | |||
There was a problem hiding this comment.
I only bumped to 1.32.2 based on what the @storybook/test-runner had in the latest version (v0.15.2)
thmsobrmlr
pushed a commit
that referenced
this pull request
Nov 23, 2023
* chore: upgrade playwright * remove core * upgrade container image * use test-runner version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Playwright wasn't working locally for me
Changes
Upgraded to the latest version following the release notes
How did you test this code?
Hopefully this runs...