fix(tests): upgrade playwright #20441
Conversation
📸 UI snapshots have been updated123 snapshot changes in total. 0 added, 123 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 864 kB ℹ️ View Unchanged
|
| @@ -54,7 +54,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| timeout-minutes: 30 | |||
| container: | |||
| image: mcr.microsoft.com/playwright:v1.32.2 # Same as @storybook/[email protected]'s dependency | |||
| image: mcr.microsoft.com/playwright:v1.41.2 | |||
There was a problem hiding this comment.
@daibhin I saw that you added the initial comment regarding the version lock to 1.32.2 here. The dependency is still locked to the same version via @storybook/[email protected] -> [email protected] -> [email protected]. Since the CI run is successful I'm assuming everything works with a newer version, but let me know if there's an issue that you know about and that isn't obvious to me.
There was a problem hiding this comment.
Don't recall the exact context of the comment but I'd imagine it's safe to upgrade. Most likely my CI wasn't passing without it but I think we've even upgraded Storybook a couple of times since so perhaps they loosened their dependencies somewhat
| @@ -54,7 +54,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| timeout-minutes: 30 | |||
| container: | |||
| image: mcr.microsoft.com/playwright:v1.32.2 # Same as @storybook/[email protected]'s dependency | |||
| image: mcr.microsoft.com/playwright:v1.41.2 | |||
There was a problem hiding this comment.
Don't recall the exact context of the comment but I'd imagine it's safe to upgrade. Most likely my CI wasn't passing without it but I think we've even upgraded Storybook a couple of times since so perhaps they loosened their dependencies somewhat
There was a problem hiding this comment.
Wild how many snapshots (especially in one area) are being updated by one change. Seems unrelated to anything you've done @thmsobrmlr but maybe we need to reduce the tolerance slightly on snapshots
There was a problem hiding this comment.
Yeah I think that's because font rendering got changed slightly and they now go above the threshold (they have been outdated since we've increased the contrast). Will keep a look on how the test behave.
# Conflicts: # frontend/__snapshots__/scenes-app-insights--trends-line--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-table-breakdown-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights-error-empty-states--estimated-query-execution-time-too-long--light.png
Problem
A visual regression test is flip-flopping dc7de36. It's always the first test of the insight stories and looks like it's flip-flopping the width of the scrollbar. There are a couple of bug reports in playwright (1, 2, 3, 4) that might be related to this (might also be something else) with various workarounds, but a fix might also be in the latest version.
Changes
Upgrades playwright to the latest version.
How did you test this code?
CI run