feat(django): allow elements chain as string for certain teams #18701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.99 MB ℹ️ View Unchanged
|
…ostHog/posthog into dave/add-elements-chain-flag-in-decide
2 tasks
tomasfarias
reviewed
Nov 20, 2023
| @@ -37,3 +37,5 @@ | |||
| NEW_ANALYTICS_CAPTURE_ENDPOINT = os.getenv("NEW_CAPTURE_ENDPOINT", "/i/v0/e/") | |||
| NEW_ANALYTICS_CAPTURE_TEAM_IDS = get_set(os.getenv("NEW_ANALYTICS_CAPTURE_TEAM_IDS", "")) | |||
| NEW_ANALYTICS_CAPTURE_SAMPLING_RATE = get_from_env("NEW_ANALYTICS_CAPTURE_SAMPLING_RATE", type_cast=float, default=1.0) | |||
|
|
|||
| ELEMENT_CHAIN_AS_STRING_TEAMS = get_set(os.getenv("ELEMENT_CHAIN_AS_STRING_TEAMS", "")) | |||
There was a problem hiding this comment.
I wasn't aware we had a get_set, could have used that... Nice!
tomasfarias
reviewed
Nov 20, 2023
posthog/api/test/test_decide.py
Outdated
| @@ -2991,6 +2991,20 @@ def test_decide_new_capture_activation(self, *args): | |||
| self.assertEqual(response.status_code, 200) | |||
| self.assertFalse("analytics" in response.json()) | |||
|
|
|||
| @patch("posthog.models.feature_flag.flag_analytics.CACHE_BUCKET_SIZE", 10) | |||
There was a problem hiding this comment.
nit: I don't think we need this mock for this test.
tiina303
approved these changes
Nov 20, 2023
# Conflicts: # posthog/api/test/test_decide.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As part of killing elements parsing in plugin-server (#18418), we need to send elements chain as a string from the client (PostHog/posthog-js#823).
Changes
This will add a flag (
elementsChainAsString) in decide response to allow returning elements chain as a string rather than JSON object ifELEMENT_CHAIN_AS_STRING_TEAMSis set and includes the current team idRelated PR: https://github.com/PostHog/posthog-cloud-infra/pull/2314
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Added a unit test for when ELEMENT_CHAIN_AS_STRING_TEAMS is set and not set