feat(django): Remove allowlist for elements_chain in decide #19332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvello
approved these changes
Dec 14, 2023
| settings.ELEMENT_CHAIN_AS_STRING_EXCLUDED_TEAMS is None | ||
| or str(team.id) not in settings.ELEMENT_CHAIN_AS_STRING_EXCLUDED_TEAMS | ||
| ) | ||
| settings.ELEMENT_CHAIN_AS_STRING_EXCLUDED_TEAMS |
There was a problem hiding this comment.
nit: giving an empty ELEMENT_CHAIN_AS_STRING_EXCLUDED_TEAMS would not release it for everyone, but disable it for everyone, which feels counter-intuitive. I'd remove this check, unless that's your intent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Next step in enabling elements_chain processing on client. Previously had both allowlist and denylist. Large teams already in denylist. Removing allowlist now. Clients need to be on
posthog-js > 1.92.0to sendelements_chaindirectly so we'll still see the old behavior for a while until clients get updated.Related PRs:
PostHog/posthog-js#823
#18701
#19193
Changes
Removed allowlist check in decide
How did you test this code?
Updated tests to be denylist only