Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend): Sort imports with ESLint #18663

Merged
merged 23 commits into from
Nov 22, 2023
Merged

chore(frontend): Sort imports with ESLint #18663

merged 23 commits into from
Nov 22, 2023

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Nov 15, 2023

Changes

Long overdue: sorting of imports in the frontend. I added it to the plugin-server 2.5 year ago, but we never got to it in the frontend. Until now.

Zero changes other than the order of imports in this PR.

@Twixes Twixes requested review from mariusandra and a team November 15, 2023 19:39
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

@daibhin daibhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend merging this asap to avoid merge conflicts. Probably safe to merge without checks passing to save time. Or else split it into multiple PRs that apply the changes to individual directories and then add the rule in a final PR

@Twixes Twixes marked this pull request as ready for review November 16, 2023 17:07
@Twixes Twixes enabled auto-merge (squash) November 16, 2023 17:07
Copy link
Contributor

github-actions bot commented Nov 16, 2023

Size Change: -46 B (0%)

Total Size: 1.97 MB

Filename Size Change
frontend/dist/toolbar.js 1.97 MB -46 B (0%)

compressed-size-action

@Twixes Twixes disabled auto-merge November 20, 2023 10:12
@PostHog PostHog deleted a comment from posthog-bot Nov 22, 2023
@PostHog PostHog deleted a comment from posthog-bot Nov 22, 2023
@PostHog PostHog deleted a comment from posthog-bot Nov 22, 2023
@PostHog PostHog deleted a comment from posthog-bot Nov 22, 2023
@PostHog PostHog deleted a comment from posthog-bot Nov 22, 2023
@PostHog PostHog deleted a comment from posthog-bot Nov 22, 2023
@PostHog PostHog deleted a comment from posthog-bot Nov 22, 2023
@PostHog PostHog deleted a comment from posthog-bot Nov 22, 2023
@PostHog PostHog deleted a comment from posthog-bot Nov 22, 2023
@PostHog PostHog deleted a comment from posthog-bot Nov 22, 2023
@PostHog PostHog deleted a comment from posthog-bot Nov 22, 2023
@PostHog PostHog deleted a comment from posthog-bot Nov 22, 2023
@PostHog PostHog deleted a comment from posthog-bot Nov 22, 2023
@PostHog PostHog deleted a comment from posthog-bot Nov 22, 2023
@PostHog PostHog deleted a comment from posthog-bot Nov 22, 2023
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Twixes Twixes merged commit 69becac into master Nov 22, 2023
74 checks passed
@Twixes Twixes deleted the sort-imports branch November 22, 2023 14:07
@Twixes Twixes changed the title chore(frontend): Sort imports chore(frontend): Sort imports with ESLint Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants