Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): Remove Ant component #18622

Closed
wants to merge 0 commits into from
Closed

refactor(frontend): Remove Ant component #18622

wants to merge 0 commits into from

Conversation

rogemus
Copy link

@rogemus rogemus commented Nov 14, 2023

Changes

  • Replace Switch with LeonSwitch
  • Replace Skeleton with LemonSkeleton

Relates to #13624

@rogemus
Copy link
Author

rogemus commented Nov 14, 2023

Question to posthog team - do you prefer to import like that:
import { X } from 'lib/lemon-ui/X or import { X } from '@posthog/lemon-ui'
I've seen both in code.

Also, your imports are a bit messy. Would be OK if I sort them in the files I'm changing?

@rogemus rogemus changed the title Remove Ant component [WIP] Remove Ant component Nov 14, 2023
@rogemus rogemus changed the title [WIP] Remove Ant component refactor(frontend) [WIP] Remove Ant component Nov 16, 2023
@rogemus rogemus changed the title refactor(frontend) [WIP] Remove Ant component refactor(frontend): [WIP] Remove Ant component Nov 16, 2023
@rogemus rogemus marked this pull request as draft November 16, 2023 15:32
@rogemus rogemus changed the title refactor(frontend): [WIP] Remove Ant component refactor(frontend): Remove Ant component Nov 16, 2023
@rogemus rogemus mentioned this pull request Nov 17, 2023
59 tasks
@Twixes
Copy link
Member

Twixes commented Nov 21, 2023

Hey @kacper-rogowski-wttech! Is this ready for review?

@rogemus
Copy link
Author

rogemus commented Nov 27, 2023

@Twixes hi, @kacper-rogowski-wttech is my corporate username.

Sadly after some changes on master, I have conflicts in 20+ files, I will resolve them and mark PR as ready for review :D

@Twixes
Copy link
Member

Twixes commented Nov 27, 2023

Most of the conflicts are probably from #18663 (hopefuly), so should be easy to resolve.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@mariusandra mariusandra removed the stale label Dec 5, 2023
@rogemus rogemus closed this Dec 8, 2023
@rogemus
Copy link
Author

rogemus commented Dec 8, 2023

Due to conflicts and a lot of changes on master I've closed this pr and open new one, which is much smaller and easier to review.

New PR
#19216

FYI @Twixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants