fix(insights): fix insights display configs in notebooks #18456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
changed the title
daibhin
reviewed
Nov 7, 2023
mariusandra
approved these changes
Nov 7, 2023
Co-authored-by: David Newell <[email protected]>
|
@MarconLP If you see anything that breaks editing insights or insights in experiments, this PR is likely it. Please let me know if that's the case. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
thmsobrmlr
added a commit
that referenced
this pull request
Nov 8, 2023
)" This reverts commit ccd53c1.
thmsobrmlr
added a commit
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We decided to move forward with #18266 and #18257 to work around the issues with insight queries not updating in notebooks. (Note: both these PRs would not have been necessary with the
propsQuerychange mentioned further below).The
readOnlyprop is preventing this to work andshowHeaders: falseis hiding the filters.This still did not fix all the issues with notebooks, but removing the
propsQuerydid. I have no idea why, but could not find any problems in insights / dashboards / experiments. Thus suggesting we move forward with this and 🤞 everything works. If this causes any issues, we roll back the change.Changes
This PR removes the
readOnlyprop, un-hides the filters and removes thepropsQueryfrom the query selector.How did you test this code?
Tested that editing the