fix(insights): fix insights display configs in notebooks (#18456)

* feat(notebooks): allow editing the insight config in notebooks * remove propsQuery * show header * Update frontend/src/scenes/notebooks/Nodes/NotebookNodeQuery.tsx Co-authored-by: David Newell <[email protected]> --------- Co-authored-by: David Newell <[email protected]>
PostHog · Nov 7, 2023 · ccd53c1 · ccd53c1
1 parent fb80cae
commit ccd53c1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/frontend/src/scenes/insights/insightDataLogic.ts b/frontend/src/scenes/insights/insightDataLogic.ts
@@ -84,21 +84,14 @@ export const insightDataLogic = kea<insightDataLogicType>([
 
     selectors({
         query: [
-            (s) => [s.propsQuery, s.filters, s.insight, s.internalQuery, s.filterTestAccountsDefault],
-            (propsQuery, filters, insight, internalQuery, filterTestAccountsDefault) =>
-                propsQuery ||
+            (s) => [s.filters, s.insight, s.internalQuery, s.filterTestAccountsDefault],
+            (filters, insight, internalQuery, filterTestAccountsDefault) =>
                 internalQuery ||
                 insight.query ||
                 (filters && filters.insight ? queryFromFilters(filters) : undefined) ||
                 queryFromKind(NodeKind.TrendsQuery, filterTestAccountsDefault),
         ],
 
-        propsQuery: [
-            () => [(_, props) => props],
-            // overwrite query from props for standalone InsightVizNode queries
-            (props: InsightLogicProps) => (props.dashboardItemId?.startsWith('new-AdHoc.') ? props.query : null),
-        ],
-
         isQueryBasedInsight: [
             (s) => [s.query],
             (query) => {

diff --git a/frontend/src/scenes/notebooks/Nodes/NotebookNodeQuery.tsx b/frontend/src/scenes/notebooks/Nodes/NotebookNodeQuery.tsx
@@ -87,7 +87,7 @@ const Component = ({ attributes }: NotebookNodeProps<NotebookNodeQueryAttributes
         <div
             className={clsx('flex flex-1 flex-col', NodeKind.DataTableNode === modifiedQuery.kind && 'overflow-hidden')}
         >
-            <Query query={modifiedQuery} uniqueKey={nodeId} readOnly={true} />
+            <Query query={modifiedQuery} uniqueKey={nodeId} />
         </div>
     )
 }
@@ -126,6 +126,7 @@ export const Settings = ({
 
         if (NodeKind.InsightVizNode === modifiedQuery.kind || NodeKind.SavedInsightNode === modifiedQuery.kind) {
             modifiedQuery.showFilters = true
+            modifiedQuery.showHeader = true
             modifiedQuery.showResults = false
             modifiedQuery.embedded = true
         }