feat(3000): Breadcrumbs bar as dynamic page header #18426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
requested review from
corywatilo,
benjackwhite and
a team
and removed request for
benjackwhite
benjackwhite
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
This is so cool! I think it really nicely solves the problem.
Taste-wise the expanded heading still looks quite cramped... Maybe is just something we could get used to but I feel like a tiny bit more space between it and its surroundings could be nice.
It assumes the main area is always scrollable which we sort of break for Notebooks and Replay but I think thats totally fine and we can fix those areas to work with the parent scroller instead.
Twixes
force-pushed
the
3000-top-bar-system
branch
from
a6cc1c1 to
9c439ee
Compare
Twixes
force-pushed
the
3000-top-bar-system
branch
from
c06e873 to
4df7ba2
Compare
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
Twixes
force-pushed
the
3000-top-bar-system
branch
from
8b0bab5 to
ff23b43
Compare
daibhin
added a commit
that referenced
this pull request
Nov 14, 2023
* Disable double-tap-to-zoom in our app * Add prominent scene title to breadcrumbs * Render page-level actions next to breadcrumbs * Fix overflow occasionally caused by `InsightTooltip` * Fix word wrap * Make spacing more relaxed * Keep breadcrumb highlighted when popover active * Resolve cyclic import * Tune top bar sizing * Fix import problem * Fix a couple more issues in stories * Update UI snapshots for `chromium` (1) * Wait for loaders more reliably --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We had two page headers in 3000 mode, and neither looked great.
Changes
The breadcrumbs bar is now the page header, and it adjusts based on where you are on the page.