fix(3000): Reconnect submit buttons in PageHeader to forms #18602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
commented
Nov 14, 2023
| @@ -50,7 +50,7 @@ export function SurveyForm({ id }: { id: string }): JSX.Element { | |||
| const { loadSurvey, editingSurvey } = useActions(surveyLogic) | |||
|
|
|||
| return ( | |||
| <Form formKey="survey" logic={surveyLogic} className="space-y-4" enableFormOnSubmit> | |||
| <Form id="survey" formKey="survey" logic={surveyLogic} className="space-y-4" enableFormOnSubmit> | |||
There was a problem hiding this comment.
@mariusandra Do you think it'd make sense for kea-forms to add an ID automatically based on logic key + formKey? Or would that be annoying?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#18426 moved the buttons to a portal in 3000 mode, and the portal happens to render that HTML in the breadcrumbs bar – outside of any
that the may be in. So "Save" buttons in scenes like action or cohort editing don't work in 3000 mode.Changes
Fixes the above my explicitly linking these buttons to their forms.
How did you test this code?
Codebase search + clicking. This would be prevented by E2E tests on 3000 UI, but we're still at a stage where that doesn't seem like a must.