Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(command-bar): add commands from existing palette #18355

Merged
merged 29 commits into from
Nov 14, 2023
Merged

feat(command-bar): add commands from existing palette #18355

merged 29 commits into from
Nov 14, 2023

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Nov 2, 2023 •
edited
Loading

Problem

Follow up to #17864.

Changes

This PR adds a CMD+SHIFT+K menu displaying the commands from the existing CMD+K palette.

Follow up work: #18552

How did you test this code?

Tested locally

@thmsobrmlr thmsobrmlr mentioned this pull request Nov 2, 2023
Merged
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr thmsobrmlr mentioned this pull request Nov 10, 2023
Open
24 tasks
@thmsobrmlr thmsobrmlr marked this pull request as ready for review November 10, 2023 16:03
@thmsobrmlr thmsobrmlr requested a review from a team November 11, 2023 20:05
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

daibhin
daibhin reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@daibhin daibhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left some UX comments on the first file randomly so that you can reply individually if needed. I know you wanted to get this out and follow up with UX fixes afterwards so nothing blocking from me

frontend/__snapshots__/scenes-app-insights--retention--webkit.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placeholder didn't render when doing CMD+K (it did with CMD+SHIFT+K)
placeholder

frontend/__snapshots__/scenes-app-insights--retention--webkit.png Show resolved Hide resolved
frontend/__snapshots__/scenes-app-insights--retention--webkit.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't clear what this action does (I assume it opens the toolbar). Do we need some kind of description?
Screenshot 2023-11-13 at 09 57 04

frontend/__snapshots__/scenes-app-insights--retention--webkit.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blank space below the options looked weird to me. Maybe it should be the same color as the options Screenshot 2023-11-13 at 09 56 23

benjackwhite
benjackwhite reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick skim and all looked fine. Other than a comment I will try and check it out and try it out myseld

frontend/src/lib/components/CommandBar/ActionResults.tsx Show resolved Hide resolved
@thmsobrmlr thmsobrmlr merged commit 7657de5 into command-bar Nov 14, 2023
70 of 71 checks passed
@thmsobrmlr thmsobrmlr deleted the command-bar-actions branch November 14, 2023 11:36
@thmsobrmlr thmsobrmlr mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daibhin daibhin daibhin left review comments

@benjackwhite benjackwhite benjackwhite left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thmsobrmlr @posthog-bot @benjackwhite @daibhin