Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(command-bar): various improvements to the command bar #18649

Merged
merged 13 commits into from
Nov 16, 2023

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Nov 15, 2023

Problem

Follow up to #17864 and #18355.

Changes

This PR:

  • replaces the lemon modal with a custom one, without a transition
  • handles entering command mode when replacing the input with ">"
  • replaces the height attribute added to lemon skeleton by adding a the height to the default className that can be overwritten by setting in a custom className
  • replaces default with named exports
  • some smaller fixes

How did you test this code?

Clicking around

@thmsobrmlr thmsobrmlr changed the title Command bar improvements feat(command-bar): various improvements to the command bar Nov 15, 2023
@thmsobrmlr thmsobrmlr force-pushed the command-bar-improvements branch from 2add97e to 1e0294d Compare November 15, 2023 13:47
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr thmsobrmlr marked this pull request as ready for review November 15, 2023 15:29
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr thmsobrmlr requested a review from a team November 15, 2023 17:19
@thmsobrmlr thmsobrmlr enabled auto-merge (squash) November 16, 2023 10:52
Copy link
Contributor

Size Change: -2.51 kB (0%)

Total Size: 2.01 MB

Filename Size Change
frontend/dist/toolbar.js 2.01 MB -2.51 kB (0%)

compressed-size-action

@thmsobrmlr thmsobrmlr merged commit 1c0ffda into master Nov 16, 2023
74 checks passed
@thmsobrmlr thmsobrmlr deleted the command-bar-improvements branch November 16, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants