Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unhandledRejection types are looser than assumed #18286

Merged
merged 3 commits into from
Oct 31, 2023
Merged

fix: unhandledRejection types are looser than assumed #18286

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8187445
fix: unhandledRejection types are looser than assumed
pauldambra Oct 30, 2023
9c1280d
simpler than that
pauldambra Oct 30, 2023
fd2f8b2
delegate logging the things to the log framework - which should at le…
pauldambra Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugin-server/src/main/pluginsServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ export async function startPluginsServer(
27, // REBALANCE_IN_PROGRESS
])

process.on('unhandledRejection', (error: Error) => {
status.error('🤮', `Unhandled Promise Rejection: ${error.stack}`)
process.on('unhandledRejection', (error: Error | any, promise: Promise<any>) => {
status.error('🤮', `Unhandled Promise Rejection: ${error} for promise: ${promise}`)

if (error instanceof KafkaJSProtocolError) {
kafkaProtocolErrors.inc({
Expand Down
Loading