fix: unhandledRejection types are looser than assumed #18286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a period of c 90 minutes where blob ingestion was failing to start
See https://posthog.slack.com/archives/C0185UNBSJZ/p1698707508193559?thread_ts=1698684867.238139&cid=C0185UNBSJZ
The errors that were (maybe) causing this were hidden because a top level handler for
unhandledRejection
assumed that it always received anError
from which it could readstack
Slightly ridiculously the error being received was
undefined
https://posthog.sentry.io/issues/4410219272/?query=is%3Aunresolved+PLUGIN_SERVER_MODE%3Arecordings-blob-ingestion&referrer=issue-stream&statsPeriod=1h&stream_index=2Looking at https://nodejs.org/docs/latest-v18.x/api/process.html#event-unhandledrejection the signature for the handler is
This changes the handler to log the error without trying to read its properties, bringing the log message to almost match the example from the docs