fix(insights): fix display changes for standalone queries #18266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this made any improvements to notebooks. You can see some changes because the annotations move around but the visualization never updates |
|
(Somewhat a note to myself). Using these changes working.patch I could get the insight filters working. Don't want to commit here, since the changes are somewhat unrelated and I don't know what the exact implications are of we disable readOnly mode here.
|
mariusandra
approved these changes
Nov 6, 2023
thmsobrmlr
force-pushed
the
fix-chart-filter-logic
branch
from
52c5684 to
df8ca83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #18256 (Issue 3 + Issue 4)
Changes
chartFilterLogic, that previously connected toinsightVizDataLogic`, with direct usages of that logicchartFilterLogicto thehandleQuerySourceUpdateSideEffectsfunction that is called for all query source changesHow did you test this code?
Manual testing