Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR is a showcase/repro for some of the issue we have with insight logics. It's not meant to go in, ever.
Issue 1: Race condition between updates to date range and interval
dateRange
, but aninterval: "day"
got addedWorkaround:
updateQuerySource
listener inintervalFilterLogic
dateRange
gets updated (both in the insight and the playground query in the<pre />
, NOT in the date filter itself - see below)Issue 2: Dates not updating in connecting logic
Observe that the date filter does not get updated when performing the steps above.
In
InsightDateFilter
replacewith
Observe that the date filter now updates correctly
Issue 3/4: Display not updating in connecting logic; Race condition between updates to display and breakdown (when selecting world map display)
Basically the same thing as issue 1 and 2, just for the display filter.
Notes
All of this works on a regular insight page, just not when rendering a standalone
<Query />
component. Ideas on what might cause this (I'm thinking I have checked these):