Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kea): upgrade logics to v3 format with codemod (closes #18230, #18229) #18232

Merged
merged 4 commits into from
Oct 27, 2023
Merged

chore(kea): upgrade logics to v3 format with codemod (closes #18230, #18229) #18232

merged 4 commits into from
Oct 27, 2023

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Oct 26, 2023 •
edited
Loading

Problem

We were still using the kea v2 format.

Changes

This PR uses npx kea-typegen write --convert-to-builders to upgrade to the kea v3 format.

How did you test this code?

CI run & clicked through app for a bit

@thmsobrmlr thmsobrmlr mentioned this pull request Oct 26, 2023
Closed
20 tasks
@thmsobrmlr thmsobrmlr mentioned this pull request Oct 27, 2023
Closed
mariusandra
mariusandra approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from what I can tell. Didn't check everything though. 👍

@thmsobrmlr thmsobrmlr merged commit 79b5e90 into master Oct 27, 2023
75 checks passed
@thmsobrmlr thmsobrmlr deleted the kea3-via-codemod branch October 27, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thmsobrmlr @mariusandra