Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kea): upgrade current page logic to v3 #18230

Closed
wants to merge 1 commit into from
Closed

chore(kea): upgrade current page logic to v3 #18230

wants to merge 1 commit into from

Conversation

thmsobrmlr
Copy link
Contributor

Problem

See #18229.

Changes

This PR upgrades the current page logic to the kea v3 format.

How did you test this code?

CI run

@thmsobrmlr thmsobrmlr mentioned this pull request Oct 26, 2023
Closed
mariusandra
mariusandra approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@mariusandra mariusandra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative! Doesn't seem like a lot of changed files here though... Will check the other PR.

@thmsobrmlr
Copy link
Contributor Author

Ah yeah, sorry, this got superseded by #18232 when I found out there is a codemod for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thmsobrmlr @mariusandra