Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-server): clarify var name in retryIfRetriable #18093

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

bretthoerner
Copy link
Contributor

@bretthoerner bretthoerner commented Oct 19, 2023

Problem

Parameter was unclear.

Changes

Rename.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@bretthoerner bretthoerner requested a review from xvello October 19, 2023 14:52
@bretthoerner bretthoerner changed the title fix(plugin-server): only do 2 retries, for a total of 3 tries fix(plugin-server): clarify var name in retryIfRetriable Oct 19, 2023
@bretthoerner bretthoerner merged commit c8dbc68 into master Oct 19, 2023
72 checks passed
@bretthoerner bretthoerner deleted the brett/retry-2 branch October 19, 2023 15:10
Justicea83 pushed a commit to Justicea83/posthog that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants