fix(plugin-server): only do 2 retries, for a total of 3 tries

PostHog · Oct 19, 2023 · c68167a · c68167a
1 parent e968091
commit c68167a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/plugin-server/src/utils/retries.ts b/plugin-server/src/utils/retries.ts
@@ -158,7 +158,7 @@ export async function runRetriableFunction(retriableFunctionPayload: RetriableFu
 /**
  * Retry a function, respecting `error.isRetriable`.
  */
-export async function retryIfRetriable<T>(fn: () => Promise<T>, retries = 3, sleepMs = 500): Promise<T> {
+export async function retryIfRetriable<T>(fn: () => Promise<T>, retries = 2, sleepMs = 500): Promise<T> {
     for (let i = 0; i < retries; i++) {
         try {
             return await fn()

diff --git a/plugin-server/tests/main/ingestion-queues/each-batch.test.ts b/plugin-server/tests/main/ingestion-queues/each-batch.test.ts
@@ -535,7 +535,6 @@ describe('eachBatchX', () => {
             runEventPipelineSpy
                 .mockImplementationOnce(() => Promise.reject('runEventPipeline nopes out'))
                 .mockImplementationOnce(() => Promise.reject('runEventPipeline nopes out'))
-                .mockImplementationOnce(() => Promise.reject('runEventPipeline nopes out'))
             await expect(eachBatchParallelIngestion(batch, queue, IngestionOverflowMode.Disabled)).rejects.toBe(
                 'runEventPipeline nopes out'
             )