Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: log slow warnings relative to external request timeout #17821

Merged
merged 1 commit into from
Oct 5, 2023
Merged

chore: log slow warnings relative to external request timeout #17821

merged 1 commit into from
Oct 5, 2023

Conversation

tiina303
Copy link
Contributor

@tiina303 tiina303 commented Oct 5, 2023

Problem

Forgot about this, if we're chaning the timeout to 3s, then 5s slow warning would be useless

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@tiina303 tiina303 requested a review from a team October 5, 2023 17:47
bretthoerner
bretthoerner approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@bretthoerner bretthoerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I wonder if it will fire too often, and prove to be less useful with our shorter timeout? We may want to remove it and only log full timeouts depending what we see happen in prod.

@tiina303 tiina303 merged commit cc2c28a into master Oct 5, 2023
70 checks passed
@tiina303 tiina303 deleted the webhooks-slow-warnings-based-on-env branch October 5, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretthoerner bretthoerner bretthoerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiina303 @bretthoerner