chore: log slow warnings relative to external request timeout (#17821)

PostHog · Oct 5, 2023 · cc2c28a · cc2c28a
1 parent 476d102
commit cc2c28a
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/plugin-server/src/worker/ingestion/hooks.ts b/plugin-server/src/worker/ingestion/hooks.ts
@@ -364,12 +364,15 @@ export class HookCommander {
         const message = this.formatMessage(webhookUrl, action, event, team)
         end()
 
+        const slowWarningTimeout = this.EXTERNAL_REQUEST_TIMEOUT * 0.7
         const timeout = setTimeout(() => {
             status.warn(
                 '⌛',
-                `Posting Webhook slow. Timeout warning after 5 sec! url=${webhookUrl} team_id=${team.id} event_id=${event.eventUuid}`
+                `Posting Webhook slow. Timeout warning after ${
+                    slowWarningTimeout / 1000
+                } sec! url=${webhookUrl} team_id=${team.id} event_id=${event.eventUuid}`
             )
-        }, 5000)
+        }, slowWarningTimeout)
         const relevantFetch =
             isCloud() && (!this.fetchHostnameGuardTeams || this.fetchHostnameGuardTeams.has(team.id))
                 ? safeTrackedFetch
@@ -443,12 +446,15 @@ export class HookCommander {
             data: { ...data, person: sendablePerson },
         }
 
+        const slowWarningTimeout = this.EXTERNAL_REQUEST_TIMEOUT * 0.7
         const timeout = setTimeout(() => {
             status.warn(
                 '⌛',
-                `Posting RestHook slow. Timeout warning after 5 sec! url=${hook.target} team_id=${event.teamId} event_id=${event.eventUuid}`
+                `Posting RestHook slow. Timeout warning after ${slowWarningTimeout / 1000} sec! url=${
+                    hook.target
+                } team_id=${event.teamId} event_id=${event.eventUuid}`
             )
-        }, 5000)
+        }, slowWarningTimeout)
         const relevantFetch =
             isCloud() && (!this.fetchHostnameGuardTeams || this.fetchHostnameGuardTeams.has(hook.team_id))
                 ? safeTrackedFetch