-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(surveys): survey results summary #17815
Conversation
(SELECT COUNT(DISTINCT person_id) | ||
FROM events | ||
WHERE event = 'survey shown' AND properties.$survey_id = ${props.id} | ||
AND person_id NOT IN ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can do this subtraction in javascript once you get the three values, will be much faster :) - unless I'm missing a case where this count is different? 🤔
Also, add the timestamp filters like in surveyMetricsQuery
:)
Otherwise, looking good!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the above with the error states and points 1+2, otherwise good to merge since it's feature flagged 👍
…posthog into surveys/results-summary
feature flag:
surveys-results-visualizations
Implemented a stacked bar showing survey status per user
Edge case - when a sub-bar is too small, the value will overflow. In that case, I don't render the value, but there's always a tooltip available. Happy to hear feedback @corywatilo.
Testing
Manually in the browser.