feat(surveys): add Rating question results viz #17886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyiy
approved these changes
Oct 11, 2023
neilkakkar
reviewed
Oct 11, 2023
| { count: dismissed, label: 'Dismissed', color: 'bg-warning' }, | ||
| { count: sent, label: 'Submitted', color: 'bg-success' }, | ||
| ].map(({ count, label, color }) => ( | ||
| { count: seen, label: 'Viewed', style: { backgroundColor: '#1D4AFF' } }, |
There was a problem hiding this comment.
curious why this change? I think we're moving away from specific styles on components to utility classes for those styles (but not 100% sure)
There was a problem hiding this comment.
The colors suggested by Cory (#17815) are different from those available in Tailwind.
Probably worth a separate PR to make them available there.
daibhin
pushed a commit
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a bar chart for Rating results as wireframed in #17038
@corywatilo