feat: change unique idx on messsaging table #17636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #17365 we want to change the messaging record so that we can send multiple emails with the same campaign key, but only on some sort of frequency. We still need to make sure the campaign send number is is unique though so we don't try to send multiple emails at once.
Problem with that PR is that we are changing the constraint on the table, and changing constraints can have issues. So, my understanding is that we need to:
Changes
Adds a new field
campaign_count
to the MessagingRecord model.Creates a new index concurrently with a constraint including that field.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?