feat: resend email campaigns on a frequency #18148
Conversation
| ), | ||
| migrations.RunSQL( | ||
| sql=""" | ||
| ALTER TABLE posthog_messagingrecord DROP CONSTRAINT "posthog_messagingrecord_email_hash_campaign_key_6639a13f_uniq"; |
There was a problem hiding this comment.
@frankh can you confirm this is the constraint name? the 6639a13f has me concerned..
also please triple check my sql 😄
There was a problem hiding this comment.
that's definitely the name on dev, will check prod too
posthog_messagingrecord_email_hash_campaign_key_6639a13f_uniq
There was a problem hiding this comment.
same on prod:
posthog_messagingrecord_email_hash_campaign_key_6639a13f_uniq
| sql=""" | ||
| ALTER TABLE posthog_messagingrecord DROP CONSTRAINT "posthog_messagingrecord_email_hash_campaign_key_6639a13f_uniq"; | ||
| """, | ||
| reverse_sql=""" |
There was a problem hiding this comment.
i don't think we should have the reverse_sql here, if we need to rollback we should manage it manually (creating this constraint could cause the lockup issues we were trying to avoid by doing it all concurrently)
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
It looks like the code of |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Supersedes #17365 as it was split into parts.
Problem
We sometimes want to send the same email, but do so on some sort of frequency, and no more than that frequency.
For example, we want to notify CS when a
never_drop_datacustomer go over their quota - but we don't want to email CS every time we check the quota limits. But, if the problem is resolved but happens again later, we want the email to be able to be sent again.Changes
Drops the existing constraint and leverages the new one that was added in #17636.
Sets up resending based on email
resend_frequency.Adds the specific email in question described above.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Added some tests.