-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add saved insight to notebook #17551
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e631f5b
feat: add saved insight to notebook
daibhin 8fdecdc
remove line
daibhin 76ad280
Update UI snapshots for `webkit` (2)
github-actions[bot] ff756c5
Update UI snapshots for `chromium` (1)
github-actions[bot] 3b93f8d
Update UI snapshots for `chromium` (1)
github-actions[bot] 47af688
Update UI snapshots for `webkit` (2)
github-actions[bot] 89d0260
Update UI snapshots for `chromium` (1)
github-actions[bot] 58eab92
Update UI snapshots for `webkit` (2)
github-actions[bot] e1b10ff
Update UI snapshots for `chromium` (1)
github-actions[bot] e0cc564
Update UI snapshots for `webkit` (2)
github-actions[bot] 8db7a8f
Update UI snapshots for `webkit` (2)
github-actions[bot] d1a6ef1
Update UI snapshots for `webkit` (2)
github-actions[bot] 70d7d02
Update UI snapshots for `webkit` (2)
github-actions[bot] 235fd64
Merge branch 'master' into dn-feat/add-insight-to-notebook
daibhin c6920b2
mock notebooks
daibhin de7dc77
Update UI snapshots for `webkit` (2)
github-actions[bot] 160e44e
Update UI snapshots for `webkit` (2)
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+11.1 KB
(130%)
frontend/__snapshots__/scenes-app-insights--funnel-time-to-convert--webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+19.5 KB
(120%)
frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom--webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+18.9 KB
(120%)
...d/__snapshots__/scenes-app-insights--funnel-top-to-bottom-breakdown--webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+7.3 KB
(130%)
frontend/__snapshots__/scenes-app-insights--lifecycle--webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+16.5 KB
(120%)
frontend/__snapshots__/scenes-app-insights--retention-breakdown--webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+7.77 KB
(130%)
frontend/__snapshots__/scenes-app-insights--stickiness--webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+10.1 KB
(130%)
frontend/__snapshots__/scenes-app-insights--trends-area--webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+12.3 KB
(130%)
frontend/__snapshots__/scenes-app-insights--trends-line-breakdown--webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+10.5 KB
(130%)
frontend/__snapshots__/scenes-app-insights--trends-pie--webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+12.5 KB
(130%)
frontend/__snapshots__/scenes-app-insights--trends-pie-breakdown--webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+7.81 KB
(130%)
frontend/__snapshots__/scenes-app-insights--trends-table--webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+9.97 KB
(130%)
frontend/__snapshots__/scenes-app-insights--trends-table-breakdown--webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+18.4 KB
(120%)
frontend/__snapshots__/scenes-app-insights--user-paths--webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-29 KB
(10%)
...-snapshots/Navigation-App-Page-With-Side-Bar-Hidden-Mobile-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine "for now" but probably we want to come up with some combined button for adding an insight to either a dashboard or a notebook as otherwise that header could become a bit cramped