feat: add saved insight to notebook #17551
Conversation
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
| @@ -246,7 +256,18 @@ export function InsightPageHeader({ insightLogicProps }: { insightLogicProps: In | |||
| </LemonButton> | |||
| )} | |||
| {insightMode !== ItemMode.Edit && hasDashboardItemId && ( | |||
| <AddToDashboard insight={insight} setOpenModal={setAddToDashboardModalOpenModal} /> | |||
| <> | |||
| <NotebookSelectButton | |||
There was a problem hiding this comment.
I think this is fine "for now" but probably we want to come up with some combined button for adding an insight to either a dashboard or a notebook as otherwise that header could become a bit cramped
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
There is no Notebooks prompt in saved insights
Changes
Added the button (already feature flagged inside the component)
How did you test this code?
🙈