Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: embedded recordings to use blob replay #17548

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix: embedded recordings to use blob replay #17548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion frontend/src/scenes/session-recordings/player/sessionRecordingDataLogic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import { createSegments, mapSnapshotsToWindowId } from './utils/segmenter'
import { featureFlagLogic } from 'lib/logic/featureFlagLogic'
import { FEATURE_FLAGS } from 'lib/constants'
import posthog from 'posthog-js'
import { getCurrentExporterData } from '~/exporter/exporterViewLogic'

const IS_TEST_MODE = process.env.NODE_ENV === 'test'
const BUFFER_MS = 60000 // +- before and after start and end of a recording to query for.
Expand Down Expand Up @@ -208,7 +209,9 @@ export const sessionRecordingDataLogic = kea<sessionRecordingDataLogicType>([
return
}
if (!values.sessionPlayerSnapshotData?.snapshots) {
if (values.featureFlags[FEATURE_FLAGS.SESSION_RECORDING_BLOB_REPLAY]) {
// if `getCurrentExporterData` has a value then we're embedded/exported
// so, we always want to use blob replay
if (values.featureFlags[FEATURE_FLAGS.SESSION_RECORDING_BLOB_REPLAY] || getCurrentExporterData()) {
actions.loadRecordingSnapshotsV2()
} else {
actions.loadRecordingSnapshotsV1()
Expand Down