Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: embedded recordings to use blob replay #17548

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix: embedded recordings to use blob replay #17548

merged 1 commit into from
Sep 20, 2023

Conversation

pauldambra
Copy link
Member

We have the blob replay flag on for everyone... but not for embedded recordings since they don't get flags. Let's force them onto blob replay

benjackwhite
benjackwhite approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works - but why don't we just remove the flag altogether?

@pauldambra
Copy link
Member Author

pauldambra commented Sep 20, 2023 •
edited
Loading

but why don't we just remove the flag altogether?

🤯

Actually cos then there's more to test and there's too much going on all at once 🙈

@pauldambra pauldambra merged commit d24349b into master Sep 20, 2023
@pauldambra pauldambra deleted the fix/embedded-recordings-on-blob-replay branch September 20, 2023 14:54
daibhin pushed a commit that referenced this pull request Sep 21, 2023
@pauldambra @daibhin
fix: embedded recordings to use blob replay (#17548)
d89c6df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjackwhite benjackwhite benjackwhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauldambra @benjackwhite