feat: Record S3 BatchExport errors #17535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiina303
approved these changes
Sep 20, 2023
| workflow.logger.exception("BigQuery BatchExport failed.", exc_info=e) | ||
| update_inputs.status = "Failed" | ||
|
|
||
| update_inputs.latest_error = str(e.cause) |
There was a problem hiding this comment.
I'm not sure about having this, rather than it adding a log entry later when we get to it and in the mean while we can look at the workflow.logger exceptions?
| workflow.logger.exception("BigQuery BatchExport failed.", exc_info=e) | ||
| update_inputs.status = "Failed" | ||
|
|
||
| update_inputs.latest_error = str(e.cause) |
There was a problem hiding this comment.
I'm not sure about having this, rather than it adding a log entry later when we get to it and in the mean while we can look at the workflow.logger exceptions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users are not aware of what went wrong when a batch export fails. We want to add full logs, but just having a single line error message would go a long way.
Changes
Looks like this:UPDATE: Not shipping frontend changes. Will work on adding full log support instead. This PR now only has the backend updates to better track cancellations and failures.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Added unit tests for asserting behavior when catching exceptions.