refactor: BatchExport tests #17549
Closed
refactor: BatchExport tests #17549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfarias
force-pushed
the
refactor/batch-exports-tests
branch
from
098a073 to
fed0e20
Compare
tomasfarias
changed the title
Base automatically changed from
feat/report-lastest-batch-export-error
to
master
September 22, 2023 13:35
tomasfarias
changed the title
tomasfarias
force-pushed
the
refactor/batch-exports-tests
branch
from
fed0e20 to
f860144
Compare
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While working on #17535, I noticed a lot of duplication and boilerplate code in batch export tests. This makes it hard to identify what the test is about, and adding new tests requires a lot of copying and pasting.
Changes
insert_eventsto support generating test events, duplicate events, events from different teams, and events outside the export range. The events desired can be configured by function caller.insert_events.fixtures.pytobase.pyas they are not fixtures, just helper test functions.fixtures.pyas fixtures should be inconftest.py.aws:kms(although impossible via the frontend, so not critical).👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
The code is tests.