fix(trends): fix active users persons date range

[thmsobrmlr]

Problem

The persons response for active users, i.e. WAU and MAU, is off. See these tickets https://posthoghelp.zendesk.com/agent/tickets/5313, https://posthoghelp.zendesk.com/agent/tickets/5126.

Changes

As often, understanding what is going on is the hardest part of solving the problem:

• Calculation of active users: To calculate active users we take the cartesian product of eligible events* and dates for which we want to know the active users, then filter out rows where event.timestamp <= start_of_day + 1 day and event > start_of_day - 6 days (or - 29 for MAU). Grouping the rows by start_of_day yields the active users count.
• Building the persons url: The persons url for active users is built on the backend, whereby
  • date_from would be start_of_day and
  • date_to would be offset_time_series_date_by_interval(start_of_day), resulting in
    • end_of_day for a daily interval and
    • start_of_day + 6 days for weekly interval (etc. for other intervals)
• Building the final filters: The date_from is adjusted by the get_active_user_params method, by subtracting 7 / 30 days.

(*) there is actually a bug due to which the first interval doesn't receive all events it should #14063

This PR fixed the calculation by offsetting the date_from by one day. A skipped test case is added for the breakdown case, where it is not yet fixed (also do to another issue with the breakdown case, where values would not be displayed for all dates likely due to a wrong base for the aforementioned cross product). The goal now is to instead convert existing insights to HogQL and fix the remaining edge cases then.

How did you test this code?

Manually sent test events, with a separate user for each day:

curl -v -L --header "Content-Type: application/json" -d '{
  "api_key": "<ph_project_api_key>",
  "event": "my_wau_event",
  "distinct_id": "day_31_08_2023",
  "timestamp": "2023‐08‐31T13:37:42Z"
}' http://localhost:8000/capture/

Then tested responses with a deactivated cache.

[mariusandra]

Looks like black magic. Here's my LGTM if you want a TGIF.