Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(retention): move weekly active users interval by a day #17342

Closed
wants to merge 2 commits into from

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Sep 7, 2023

Problem

The retention insight and the retention persons modal seem to be using wrong query ranges independently.

The insight query is built by using the cartesian product of eligible events and the individual dates, then filtering out by event <= day + 1 and event > day - 6.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@thmsobrmlr thmsobrmlr changed the title fix(retention): move retention interval by a day fix(retention): move weekly active users interval by a day Sep 7, 2023
@thmsobrmlr
Copy link
Contributor Author

Closing in favor of #17356

@thmsobrmlr thmsobrmlr closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant