fix(insights): Fix property filter group and expression UI #15758
Conversation
|
Ahh, Storybook only shows legacy UI, not data exploration… Do you think data exploration is in a state where all of Storybook can have that flag on, or should we still have both branches covered @thmsobrmlr? |
📸 UI snapshots have been updated7 snapshot changes in total. 0 added, 7 modified, 0 deleted:
Triggered by this commit. |
1 similar comment
📸 UI snapshots have been updated7 snapshot changes in total. 0 added, 7 modified, 0 deleted:
Triggered by this commit. |
Yup, it's coming here #15497. The PR should be ready to go apart from a Jest test that I need to fix and go in on Tuesday. Took a while to get this ready since "simply toggling the flag" affected a good chunk of tests and I discovered some issues with Experiments and Notebooks. |
Twixes
force-pushed
the
fix-filtering-ui
branch
5 times, most recently
from
6204545 to
2b06591
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
frontend/src/lib/components/PropertyFilters/PropertyFilters.scss
Outdated
Show resolved
Hide resolved
Twixes
force-pushed
the
fix-filtering-ui
branch
2 times, most recently
from
9d88b19 to
4f9e74e
Compare
|
Looks like Firefox visual regression tests have a memory leak and I've found no way to fix this. :/ Will probably remove Firefox in a separate PR. |
Problem
This was a bit ugly:
Changes
This looks better:
How did you test this code?
Added UI snapshots for insight editors.