Skip to content

Commit

Permalink
Try to fix OOM in CI
Browse files Browse the repository at this point in the history
  • Loading branch information
Twixes committed May 29, 2023
1 parent b3721c8 commit 2b06591
Show file tree
Hide file tree
Showing 4 changed files with 2,064 additions and 520 deletions.
10 changes: 6 additions & 4 deletions .github/workflows/storybook-chromatic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
runs-on: ubuntu-20.04
timeout-minutes: 30
container:
image: mcr.microsoft.com/playwright:v1.29.2-focal
image: mcr.microsoft.com/playwright:v1.34.3-focal
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -107,12 +107,14 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: 8.x.x
version: 7.x.x # pnpm 8 requires Node 16.14+, see below why we need 16.10

- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 18
# Pinning Node to 16.10 as Jest suffers from a memory leak on 16.11+ (including 17, 18, 19, 20...)
# See https://github.com/storybookjs/test-runner/issues/185#issuecomment-1494227439
node-version: 16.10.x
cache: pnpm

- name: Install package.json dependencies with pnpm
Expand All @@ -122,7 +124,7 @@ jobs:
run: pnpm install http-server wait-on

- name: Build Storybook
run: pnpm build-storybook --quiet # Silence since progress logging results in a massive wall of spam
run: pnpm exec build-storybook --quiet # Silence since progress logging results in a massive wall of spam

- name: Serve Storybook in the background
run: |
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.playwright
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# We do this to ensure our reference images for visual regression tests are the same during development and in CI.
#

FROM mcr.microsoft.com/playwright:v1.29.2-focal
FROM mcr.microsoft.com/playwright:v1.34.3-focal

WORKDIR /work

Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@
"@babel/runtime": "^7.17.9",
"@cypress/webpack-preprocessor": "^5.17.1",
"@hot-loader/react-dom": "^16.14.0",
"@playwright/test": "1.29.2",
"@playwright/test": "1.34.3",
"@sentry/types": "7.22.0",
"@storybook/addon-a11y": "^6.5.16",
"@storybook/addon-actions": "^6.5.16",
Expand All @@ -183,7 +183,7 @@
"@storybook/core-events": "^6.5.16",
"@storybook/react": "^6.5.16",
"@storybook/source-loader": "^6.5.16",
"@storybook/test-runner": "^0.9.4",
"@storybook/test-runner": "^0.10.0",
"@storybook/theming": "^6.5.16",
"@sucrase/jest-plugin": "^3.0.0",
"@testing-library/dom": ">=7.21.4",
Expand Down Expand Up @@ -251,7 +251,7 @@
"msw": "^0.49.0",
"path-browserify": "^1.0.1",
"pixelmatch": "^5.3.0",
"playwright-core": "1.29.2",
"playwright-core": "1.34.3",
"pngjs": "^6.0.0",
"postcss": "^8.4.14",
"postcss-loader": "^4.3.0",
Expand Down
Loading

0 comments on commit 2b06591

Please sign in to comment.