-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hogql): select statements #14131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also ready for a review now.
limitByClause: LIMIT limitExpr BY columnExprList; | ||
limitClause: LIMIT limitExpr (WITH TIES)?; | ||
limitClause: LIMIT limitExpr ((WITH TIES) | BY columnExprList)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked and CH doesn't support BOTH a "with ties" and a "by x" ending on "limit" at the same time, though the parser seemed to allow it. Fixed.
79095aa
to
9cd96bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't find a hole in this. LGTM
We are here now
Changes
Basic full SELECT support for HogQL
Support for WITH, ARRAY JOIN and window functions, along with printing support for JOINS (they're being parsed), is outside the scope of this PR.
All of those require "alias resolution" to work well, which is a chunk of work big enough it needs its own PR. I'd like to get just basic SELECT support merged for that.
How did you test this code?
Many new tests here.