feat(hogql): better error if placeholder in HogQL expression #14153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
Throws a slightly nicer looking error when accidentally using
{placeholder}
syntax within HogQL expressions, for example in insights or in the events table.The previous error looked like we had explicitly forgotten to add a placeholder, while it was actually bad data. This makes it clear that no placeholders are allowed in user entered strings.
It's all part of a work in progress though...
How did you test this code?
Added a test.