Move suppressSessionAnalysisWarning to insightViz

PostHog · Nov 9, 2023 · 76f88e0 · 76f88e0
1 parent b44b19b
commit 76f88e0
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/frontend/src/queries/schema.ts b/frontend/src/queries/schema.ts
@@ -397,6 +397,7 @@ interface InsightVizNodeViewProps {
     showResults?: boolean
     /** Query is embedded inside another bordered component */
     embedded?: boolean
+    suppressSessionAnalysisWarning?: boolean
 }
 
 /** Base class for insight query nodes. Should not be used directly. */

diff --git a/frontend/src/scenes/insights/insightVizDataLogic.ts b/frontend/src/scenes/insights/insightVizDataLogic.ts
@@ -172,9 +172,9 @@ export const insightVizDataLogic = kea<insightVizDataLogicType>([
             },
         ],
         shouldShowSessionAnalysisWarning: [
-            (s) => [s.isUsingSessionAnalysis, (_, p) => p.suppressSessionAnalysisWarning],
-            (isUsingSessionAnalysis, suppressSessionAnalysisWarning) =>
-                isUsingSessionAnalysis && !suppressSessionAnalysisWarning,
+            (s) => [s.isUsingSessionAnalysis, s.query],
+            (isUsingSessionAnalysis, query) =>
+                isUsingSessionAnalysis && !(isInsightVizNode(query) && query.suppressSessionAnalysisWarning),
         ],
         isNonTimeSeriesDisplay: [
             (s) => [s.display],

diff --git a/frontend/src/scenes/web-analytics/WebAnalyticsTile.tsx b/frontend/src/scenes/web-analytics/WebAnalyticsTile.tsx
@@ -194,7 +194,6 @@ export const WebStatsTrendTile = ({ query }: { query: InsightVizNode }): JSX.Ele
                     },
                 },
                 hidePersonsModal: true,
-                suppressSessionAnalysisWarning: true,
             },
         }
     }, [onWorldMapClick])

diff --git a/frontend/src/scenes/web-analytics/webAnalyticsLogic.ts b/frontend/src/scenes/web-analytics/webAnalyticsLogic.ts
@@ -315,6 +315,7 @@ export const webAnalyticsLogic = kea<webAnalyticsLogicType>([
                                         filterTestAccounts: true,
                                         properties: webAnalyticsFilters,
                                     },
+                                    suppressSessionAnalysisWarning: true,
                                 },
                             },
                         ],

diff --git a/frontend/src/types.ts b/frontend/src/types.ts
@@ -2103,7 +2103,6 @@ export interface InsightLogicProps {
     setQuery?: (node: InsightVizNode) => void
 
     hidePersonsModal?: boolean
-    suppressSessionAnalysisWarning?: boolean
     /** chart-specific rendering context **/
     chartRenderingMetadata?: ChartRenderingMetadata
 }
-Original file line number
+Diff line change
@@ Expand Up @@
                         },
                     },
                     hidePersonsModal: true,
-                    suppressSessionAnalysisWarning: true,
                 },
             }
         }, [onWorldMapClick])
@@ Expand Down @@