Hide session analysis warning on web analytics insights

PostHog · Nov 9, 2023 · b44b19b · b44b19b
1 parent 03960c1
commit b44b19b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/frontend/src/queries/nodes/InsightViz/InsightContainer.tsx b/frontend/src/queries/nodes/InsightViz/InsightContainer.tsx
@@ -82,11 +82,11 @@ export function InsightContainer({
         trendsFilter,
         funnelsFilter,
         supportsDisplay,
-        isUsingSessionAnalysis,
         samplingFactor,
         insightDataLoading,
         erroredQueryId,
         timedOutQueryId,
+        shouldShowSessionAnalysisWarning,
     } = useValues(insightVizDataLogic(insightProps))
     const { exportContext } = useValues(insightDataLogic(insightProps))
 
@@ -197,7 +197,7 @@ export function InsightContainer({
 
     return (
         <>
-            {isUsingSessionAnalysis ? (
+            {shouldShowSessionAnalysisWarning ? (
                 <div className="mb-4">
                     <LemonBanner type="info">
                         When using sessions and session properties, events without session IDs will be excluded from the

diff --git a/frontend/src/scenes/insights/insightVizDataLogic.ts b/frontend/src/scenes/insights/insightVizDataLogic.ts
@@ -171,7 +171,11 @@ export const insightVizDataLogic = kea<insightVizDataLogicType>([
                 )
             },
         ],
-
+        shouldShowSessionAnalysisWarning: [
+            (s) => [s.isUsingSessionAnalysis, (_, p) => p.suppressSessionAnalysisWarning],
+            (isUsingSessionAnalysis, suppressSessionAnalysisWarning) =>
+                isUsingSessionAnalysis && !suppressSessionAnalysisWarning,
+        ],
         isNonTimeSeriesDisplay: [
             (s) => [s.display],
             (display) => !!display && NON_TIME_SERIES_DISPLAY_TYPES.includes(display),

diff --git a/frontend/src/scenes/web-analytics/WebAnalyticsTile.tsx b/frontend/src/scenes/web-analytics/WebAnalyticsTile.tsx
@@ -194,6 +194,7 @@ export const WebStatsTrendTile = ({ query }: { query: InsightVizNode }): JSX.Ele
                     },
                 },
                 hidePersonsModal: true,
+                suppressSessionAnalysisWarning: true,
             },
         }
     }, [onWorldMapClick])

diff --git a/frontend/src/types.ts b/frontend/src/types.ts
@@ -2103,6 +2103,7 @@ export interface InsightLogicProps {
     setQuery?: (node: InsightVizNode) => void
 
     hidePersonsModal?: boolean
+    suppressSessionAnalysisWarning?: boolean
     /** chart-specific rendering context **/
     chartRenderingMetadata?: ChartRenderingMetadata
 }
-Original file line number
+Diff line change
@@ Expand Up @@
                         },
                     },
                     hidePersonsModal: true,
+                    suppressSessionAnalysisWarning: true,
                 },
             }
         }, [onWorldMapClick])
@@ Expand Down @@