Skip to content

Commit

Permalink
chore: remove gauge that has served its purpose (#26396)
Browse files Browse the repository at this point in the history
  • Loading branch information
pauldambra authored Nov 25, 2024
1 parent 317fe63 commit 7576434
Showing 1 changed file with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,6 @@ const gaugeLagMilliseconds = new Gauge({
labelNames: ['partition'],
})

const gaugePromisesInProgress = new Gauge({
name: 'recording_blob_ingestion_promises_in_progress',
help: 'A gauge of the number of promises in progress',
})

// NOTE: This gauge is important! It is used as our primary metric for scaling up / down
const gaugeLag = new Gauge({
name: 'recording_blob_ingestion_lag',
Expand Down Expand Up @@ -402,8 +397,6 @@ export class SessionRecordingIngester {

await this.reportPartitionMetrics()

gaugePromisesInProgress.set(this.promises.size)

await runInstrumentedFunction({
statsKey: `recordingingester.handleEachBatch.consumeBatch`,
func: async () => {
Expand Down Expand Up @@ -599,7 +592,6 @@ export class SessionRecordingIngester {
void this.scheduleWork(this.realtimeManager.unsubscribe())

const promiseResults = await Promise.allSettled(this.promises)
gaugePromisesInProgress.remove()

if (this.sharedClusterProducerWrapper) {
await this.sharedClusterProducerWrapper.disconnect()
Expand Down

0 comments on commit 7576434

Please sign in to comment.