fix: better stack trace colors (#26393)

PostHog · Nov 25, 2024 · 317fe63 · 317fe63
1 parent 94c2b0a
commit 317fe63
Show file tree

Hide file tree

Showing 8 changed files with 3 additions and 3 deletions.
diff --git a/frontend/__snapshots__/components-errors-error-display--stacktraceless--dark.png b/frontend/__snapshots__/components-errors-error-display--stacktraceless--dark.png
diff --git a/frontend/__snapshots__/components-errors-error-display--stacktraceless--light.png b/frontend/__snapshots__/components-errors-error-display--stacktraceless--light.png
diff --git a/frontend/__snapshots__/components-playerinspector-itemevent--error-event--dark.png b/frontend/__snapshots__/components-playerinspector-itemevent--error-event--dark.png
diff --git a/...tend/__snapshots__/components-playerinspector-itemevent--error-event--light.png b/...tend/__snapshots__/components-playerinspector-itemevent--error-event--light.png
diff --git a/..._snapshots__/components-playerinspector-itemevent--sentry-error-event--dark.png b/..._snapshots__/components-playerinspector-itemevent--sentry-error-event--dark.png
diff --git a/...snapshots__/components-playerinspector-itemevent--sentry-error-event--light.png b/...snapshots__/components-playerinspector-itemevent--sentry-error-event--light.png
diff --git a/frontend/src/lib/components/Errors/ErrorDisplay.scss b/frontend/src/lib/components/Errors/ErrorDisplay.scss
@@ -2,10 +2,10 @@
     .LemonCollapsePanel__header {
         min-height: 1.875rem !important;
         padding: 0 !important;
-        background-color: var(--bg-3000);
+        background-color: var(--accent-3000);
 
         &--disabled:hover {
-            background-color: var(--bg-3000) !important;
+            background-color: var(--accent-3000) !important;
         }
     }
 }
diff --git a/frontend/src/lib/components/Errors/ErrorDisplay.tsx b/frontend/src/lib/components/Errors/ErrorDisplay.tsx
@@ -257,7 +257,7 @@ export function ErrorDisplay({ eventProperties }: { eventProperties: EventType['
                 <TitledSnack title="os" value={$os ? `${$os} ${$os_version}` : 'unknown'} />
             </div>
 
-            <LemonDivider dashed={true} />
+            {ingestionErrors || exceptionWithStack ? <LemonDivider dashed={true} /> : null}
             {ingestionErrors && (
                 <>
                     <LemonBanner type="error">