Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor decide loading #1596

Merged
merged 14 commits into from
Dec 13, 2024
Merged

fix: Refactor decide loading #1596

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1383a08
Fix up loaders
benjackwhite Dec 11, 2024
80e6e00
Fixes
benjackwhite Dec 12, 2024
7812a43
Fix
benjackwhite Dec 12, 2024
b636d87
Fix
benjackwhite Dec 12, 2024
e6df151
Fix tests
benjackwhite Dec 12, 2024
c49d42f
Fixes all round
benjackwhite Dec 12, 2024
04e5d55
fix most tests
benjackwhite Dec 12, 2024
ba6c722
Fix
benjackwhite Dec 12, 2024
f3d237a
Fixes
benjackwhite Dec 12, 2024
dcd5e8a
Fixes
benjackwhite Dec 12, 2024
d350876
Update src/posthog-featureflags.ts
benjackwhite Dec 13, 2024
ba33272
Merge branch 'main' into fix/decide-loading
benjackwhite Dec 13, 2024
2fb2d20
fix
benjackwhite Dec 13, 2024
5040141
Fixed up loading of flag
benjackwhite Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cypress/e2e/capture.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,7 @@ describe('Event capture', () => {
token: 'test_token',
distinct_id: 'new-id',
person_properties: {},
$anon_distinct_id: payload.$anon_distinct_id,
groups: {
company: 'id:5',
playlist: 'id:77',
Expand Down
2 changes: 1 addition & 1 deletion functional_tests/feature-flags.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ describe('FunctionalTests / Feature Flags', () => {
expect(getRequests(token)['/decide/']).toEqual([
// This is the initial call to the decide endpoint on PostHog init, with all info added from `loaded`.
{
// $anon_distinct_id: 'anon-id', // no anonymous ID is sent because this was overridden on load
$anon_distinct_id: 'anon-id',
benjackwhite marked this conversation as resolved.
Show resolved Hide resolved
distinct_id: 'test-id',
groups: { playlist: 'id:77' },
person_properties: {
Expand Down
4 changes: 3 additions & 1 deletion playground/nextjs/pages/_app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ export default function App({ Component, pageProps }: AppProps) {
}
}, [])

const localhostDomain = process.env.NEXT_PUBLIC_CROSSDOMAIN ? 'https://localhost:8000' : 'http://localhost:8000'
const localhostDomain = process.env.NEXT_PUBLIC_CROSSDOMAIN
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helper if runnning on localhost:8010

? 'https://localhost:8000'
: process.env.NEXT_PUBLIC_POSTHOG_HOST

return (
<PostHogProvider client={posthog}>
Expand Down
329 changes: 0 additions & 329 deletions src/__tests__/decide.ts
View file
Open in desktop

This file was deleted.

Loading