fix: Refactor decide loading #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @benjackwhite! 👋 |
|
Size Change: -8.4 kB (-0.26%) Total Size: 3.2 MB
ℹ️ View Unchanged
|
benjackwhite
commented
Dec 12, 2024
| @@ -33,7 +33,9 @@ export default function App({ Component, pageProps }: AppProps) { | |||
| } | |||
| }, []) | |||
|
|
|||
| const localhostDomain = process.env.NEXT_PUBLIC_CROSSDOMAIN ? 'https://localhost:8000' : 'http://localhost:8000' | |||
| const localhostDomain = process.env.NEXT_PUBLIC_CROSSDOMAIN | |||
There was a problem hiding this comment.
Helper if runnning on localhost:8010
| import '../entrypoints/external-scripts-loader' | ||
| import { assignableWindow } from '../utils/globals' | ||
|
|
||
| describe('RemoteConfigLoader', () => { |
There was a problem hiding this comment.
This was Decide but now it only handles config loading
| @@ -545,6 +548,14 @@ export class PostHog { | |||
| } | |||
|
|
|||
| _onRemoteConfig(config: RemoteConfig) { | |||
| if (!(document && document.body)) { | |||
There was a problem hiding this comment.
This was in decide before but should actually be here as this is the lower level call.
dmarticus
approved these changes
Dec 13, 2024
Co-authored-by: Dylan Martin <[email protected]>
pauldambra
reviewed
Dec 13, 2024
# Conflicts: # src/__tests__/featureflags.test.ts # src/decide.ts # src/posthog-core.ts # src/posthog-featureflags.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a beafy refactor that came out of me having issues around how the RemoteConfig was working.
I basically found our code is super buggy around choosing when to load flags because there were two different things calling decide with a lot of bool properties that weren't really accurate to what they were doing
The main improvements here are:
Checklist