Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sound effects #108
Add sound effects #108
Changes from 11 commits
9ee7626
2bf696d
ff89d5e
901733e
63a98ac
f6eda61
3ed1067
e15c083
7938403
aa3bc27
38fcba2
75cb98f
e65d30e
16df88a
342b73c
2cbe3e5
7c0125a
64da00e
da3280a
b044d88
0be3082
4647482
679b894
820a02f
227033e
9c5602a
30bd471
c443879
5faceb2
962e971
2d06ed6
68603ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be moved into
sound_reconfigure
. Don't forget about a flag to do loading only once.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done what I can to make this better, but might be a better way. Please let us know.